Skip to content

fix(aggregator): confirm surfaced charges after delivery - #3167

Merged
dezren39 merged 3 commits into
mainfrom
queue/4588-3122-charges-delivery
Oct 31, 2026
Merged

fix(aggregator): confirm surfaced charges after delivery#3167
dezren39 merged 3 commits into
mainfrom
queue/4588-3122-charges-delivery

Conversation

@dezren39

@dezren39 dezren39 commented Oct 31, 2026 •
edited by blacksmith-sh Bot
Loading

Copy link
Copy Markdown
Member

Summary

collect feed → scp → remote rename → confirm delivered charge keys

A per-state lock serializes concurrent pushes. Fixes #3122.

Evidence

  • Before: collection persisted keys before delivery; failed transfer suppressed subsequent alerts.
  • After: targeted charges tests: 10 passed, including simulated scp and remote rename failures, successful confirmation and concurrent pushes; push security guard passed.

Merge Danger

Door: Two-way

Blast Radius: Aggregator feed publication and charge notifications.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner October 31, 2026 17:46
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 36 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b3332059-dfe4-4dd0-a8eb-a5e463454ebe
Commits

Reviewing files that changed from the base of the PR and between c92aa62 and 5aaea6a.

Files selected for processing: 4
  • pm-stack/aggregator/scripts/collect-fleet-feed.ts
  • pm-stack/aggregator/scripts/confirm-charges-surfaced.ts
  • pm-stack/aggregator/scripts/push-fleet-feed.sh
  • pm-stack/aggregator/test/charges-push.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T18:18:59.020309Z 5aaea6a Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dezren39 dezren39 mentioned this pull request Oct 31, 2026
Closed
2 tasks
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Oct 31, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dbf6354f8e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pm-stack/aggregator/test/charges-push.test.ts Resolved
Comment thread pm-stack/aggregator/test/charges-push.test.ts Resolved
@dezren39
test(aggregator): resolve real python3 and preserve host PATH in char…
b098933 
…ges-push harness

Codex P2 x2 on PR #3167: the python3 wrapper exec-ed itself when
TEST_PYTHON3 was unset (bare name resolved back to the wrapper dir
leading PATH), and replacing PATH outright broke bash lookup on
non-Nix hosts. Resolve the interpreter to an absolute path before
installing wrappers and prepend the wrapper dir to the host PATH.
@dezren39

dezren39 commented Oct 31, 2026

Copy link
Copy Markdown
Member Author

@codex review — both P2 findings fixed in b098933, threads replied and resolved; please re-review the new head.

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Oct 31, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b0989332c9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pm-stack/aggregator/test/charges-push.test.ts Resolved
@dezren39
test(aggregator): give charges-push integration test an explicit 30s …
5aaea6a 
…timeout

Codex P2 on PR #3167 (re-review of b098933): the five subprocess
push invocations exceed the bun default 5s per-test timeout on
slower hosts. Pass an explicit 30000ms timeout to the test.
@dezren39

dezren39 commented Oct 31, 2026

Copy link
Copy Markdown
Member Author

@codex review — timeout P2 fixed in 5aaea6a, thread replied and resolved; please re-review the new head.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 5aaea6aa0e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@dezren39
dezren39 merged commit fd7ef45 into main Oct 31, 2026
1 check passed
@dezren39
dezren39 deleted the queue/4588-3122-charges-delivery branch October 31, 2026 18:20
@dezren39
dezren39 restored the queue/4588-3122-charges-delivery branch November 1, 2026 09:15
@dezren39
dezren39 deleted the queue/4588-3122-charges-delivery branch November 1, 2026 16:47
This was referenced Nov 1, 2026
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix(aggregator): charges surfaced keys are persisted before feed delivery, so a failed transfer permanently suppresses the flags (PR #2149)

1 participant

@dezren39